Change in vdsm[master]: Refactor v2v jobs for reusability

shavivi at redhat.com shavivi at redhat.com
Thu Aug 20 07:13:37 UTC 2015


Shahar Havivi has posted comments on this change.

Change subject: Refactor v2v jobs for reusability
......................................................................


Patch Set 3: Code-Review-1

Code wise is good and I on for separating the jobs,
But I don't see how did you verify???
you didn't change the API.py calls for the jobs and in sampling.py for getting the v2v jobs status!
Adam, you MUST get verify from the UI that this code works otherwise we will break the functionality.

-- 
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list