Change in vdsm[master]: netinfo: remove an assertion from getBondingForNic

osvoboda at redhat.com osvoboda at redhat.com
Wed Aug 19 21:08:32 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: remove an assertion from getBondingForNic
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/45072/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 898
Line 899
Line 900
Line 901
Line 902
> This change is wrong.
What is the likelihood that bondings, as implemented in the Linux kernel, began to accept NICs already enslaved to other bonds? I think we would not like to hear such news. I think (im)possible Linux bugs should not be caught in VDSM.

Please not that we're not checking a user's configuration, this is no longer true (if it ever has). These functions are only convenience wrappers/accessors to information acquired from the kernel.


-- 
To view, visit https://gerrit.ovirt.org/45072
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b39d3b0040c86a8c4c4babe4af03b9cf8f6bdd4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list