Change in vdsm[master]: vm: fix misleading XML log

danken at redhat.com danken at redhat.com
Wed Aug 19 10:50:00 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: vm: fix misleading XML log
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/44843/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1890: silliness
in "silliness", do you mean the odd semantics about "before_vm_start" having to start also on the dehibernate flow? Please have your TODOs more accessible to others (e.g. me)

to maintain semantics, you actually need to place this BEFORE the before_vm_dehibernate() call.


-- 
To view, visit https://gerrit.ovirt.org/44843
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50f5b8a51830c8ce2a098e4ac11dd1bd6a89aac3
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list