Change in vdsm[master]: makefile: Run pep8/pyflakes inside virtualenv

nsoffer at redhat.com nsoffer at redhat.com
Tue Aug 18 14:31:16 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: makefile: Run pep8/pyflakes inside virtualenv
......................................................................


Patch Set 2:

(2 comments)

Looks ok, but this makes the makefile even worse.

I think we should evaluate doing this with tox instead.

https://gerrit.ovirt.org/#/c/44928/2/Makefile.am
File Makefile.am:

Line 129: 			-name '*.py' -o -name '*.py.in' | 	\
Line 130: 			echo $(WHITELIST) | xargs pyflakes | \
Line 131: 			grep -w -v $(SKIP_PYFLAKES_ERR) | 	\
Line 132: 			while read LINE; do echo "$$LINE"; false; done \
Line 133: 	)
You are reimplementing tox here in an ugly way :-)

can you evaluate doing the same with tox?
Line 134: 
Line 135: .PHONY: pep8
Line 136: pep8: virtualenv
Line 137: 	(							\


Line 145: 			--exclude="$${exclude}" 		\
Line 146: 			--exclude='virtualenv/*'		\
Line 147: 			--filename '*.py,*.py.in' 		\
Line 148: 			. ;	 				\
Line 149: 	)
Second reimplementation of tox here
Line 150: 
Line 151: 
Line 152: .PHONY: python3
Line 153: python3:


-- 
To view, visit https://gerrit.ovirt.org/44928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ac3968ee6b2c9a1c9e3cf6bc78f486823bb6574
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list