Change in vdsm[ovirt-3.6]: net: create bond properly during start_devices

danken at redhat.com danken at redhat.com
Tue Aug 18 13:28:29 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: create bond properly during start_devices
......................................................................


net: create bond properly during start_devices

This method, that is used during networks rollback, calls ifup on
all ifcfg files it knows of. However, to ifup a bond, one needs to
manually create it first, by writing '+bondingName' into
/sys/class/net/bonding_masters . Ifcfg configurators already does
so when creating bonds. Skipping this step causes ifup to fail and
complain: 'Device bond11 does not seem to be present, delaying
initialization.'
This also fixes
testSetupNetworksEmergencyDevicesCleanupBondOverwrite which is
almost never run because it is a slow test.

Change-Id: Ic48f3e8b51e4e7e8668902a785c7c271ada03df6
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45027
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Continuous-Integration: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Ido Barkan: Verified
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/45027
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic48f3e8b51e4e7e8668902a785c7c271ada03df6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list