Change in vdsm[master]: net: tests: convert dummy module into a class

ibarkan at redhat.com ibarkan at redhat.com
Tue Aug 18 09:11:32 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: net: tests: convert dummy module into a class
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/44695/1/tests/functional/dummy.py
File tests/functional/dummy.py:

fixes will show up in the next commit since this code has been moved into nettestlib.py
Line 1: #
Line 2: # Copyright 2013 Red Hat, Inc.
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by


Line 33:         """
Line 34:         Create a dummy interface with a pseudo-random suffix, e.g.
Line 35:         dummy_ilXaYiSn7.
Line 36:         Limit the name to 11 characters to make room for VLAN IDs.
Line 37:         This assumes root privileges.
> this comment is not related only to create method. i'd change it into a cla
Done
Line 38:         """
Line 39:         try:
Line 40:             linkAdd(self.devName, linkType='dummy')
Line 41:         except IPRoute2Error as e:


Line 41:         except IPRoute2Error as e:
Line 42:             raise SkipTest('Failed to create a dummy interface %s: %s' %
Line 43:                            (self.devName, e))
Line 44:         else:
Line 45:             return self.devName
> do we need this? yield dummy_interface.devName would work too, but in the c
netlinkTests use it
Line 46: 
Line 47:     def remove(self):
Line 48:         """
Line 49:         Remove the dummy interface. This assumes root privileges.


-- 
To view, visit https://gerrit.ovirt.org/44695
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9c671cb0cf4b5e2e67090861e2018c90f0f95f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horacek <phoracek at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list