Change in vdsm[master]: net: tests: make monitor test_events_keys more readable

phoracek at redhat.com phoracek at redhat.com
Mon Aug 17 16:19:18 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: net: tests: make monitor test_events_keys more readable
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/44927/2/tests/netlinkTests.py
File tests/netlinkTests.py:

Line 93:                 iterator.next()
Line 94: 
Line 95:     @ValidateRunningAsRoot
Line 96:     def test_events_keys(self):
Line 97:         def _simplify_event(event):
> why do you bother with this simplification? wouldn't it hide significant va
without the simplification it would be really hard to read caught events and compare them with expected. there are many values about which we don't care and have no value for us.
Line 98:             """ Strips event keys except event, address, name, destination,
Line 99:             family.
Line 100:             """
Line 101:             allow = set(['event', 'address', 'name', 'destination', 'family'])


-- 
To view, visit https://gerrit.ovirt.org/44927
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I543c12b1d02d426472807831da3a875ec4c3289c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list