Change in vdsm[master]: multipath: Remove unneeded "features" configuration

nsoffer at redhat.com nsoffer at redhat.com
Mon Aug 17 14:59:16 UTC 2015


Nir Soffer has uploaded a new change for review.

Change subject: multipath: Remove unneeded "features" configuration
......................................................................

multipath: Remove unneeded "features" configuration

We used to override "features 0" to disable "queue_if_no_path" feature.
However, this configuration also disable other unrelated features, that
may be wanted for optimal configuration.

We use "no_path_retry fail", which removes the feature
"queue_if_no_path" if it exists in the "features" option.

For example, if a built-in device is using:

    features "3 queue_if_no_path pg_init_retries 50"

When overriding "no_path_retry fail", the device features becomes:

    features "2 pg_init_retries 50"

Now we define override only "no_path_retry fail".

Change-Id: I6c77c5a3574e3dd7ec2f740e194a6e59efc46c2a
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M lib/vdsm/tool/configurators/multipath.py
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/44943/1

diff --git a/lib/vdsm/tool/configurators/multipath.py b/lib/vdsm/tool/configurators/multipath.py
index af3edc9..124bd9d 100644
--- a/lib/vdsm/tool/configurators/multipath.py
+++ b/lib/vdsm/tool/configurators/multipath.py
@@ -72,7 +72,6 @@
         failback                immediate
         rr_weight               "uniform"
         # vdsm required configuration
-        features                "0"
         no_path_retry           fail
     }
 }
@@ -82,7 +81,6 @@
 # multipathd.
 #
 # overrides {
-#      features                "0"
 #      no_path_retry           fail
 # }
 


-- 
To view, visit https://gerrit.ovirt.org/44943
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c77c5a3574e3dd7ec2f740e194a6e59efc46c2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list