Change in vdsm[master]: network: bridge inherits DHCP unique identifier from its DHC...

osvoboda at redhat.com osvoboda at redhat.com
Sun Aug 16 13:27:22 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: network: bridge inherits DHCP unique identifier from its DHCP-enabled port
......................................................................


Patch Set 4: Verified+1

No regression with ifcfg configurator.

Failing tests are test_setupNetworks_on_external_bond, testSetupNetworksEmergencyDevicesCleanupVlanOverwrite and test_getVdsStats. testSetupNetworksResizeBond also failed once, seems flaky:

======================================================================
FAIL: testSetupNetworksResizeBond(True) (functional.networkTests.NetworkTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/share/vdsm/tests/testlib.py", line 65, in wrapper
    return f(self, *args)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 209, in wrapper
    func(*args, **kwargs)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 1389, in testSetupNetworksResizeBond
    status, msg = self.setupNetworks({}, bondings, {})
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 367, in setupNetworks
    self._assert_kernel_config_matches_running_config()
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 378, in _assert_kernel_config_matches_running_config
    self.assertEqual(normalized_config.bonds, kernel_config.bonds)
AssertionError: {'bond11': {u'nics': [u'dummy_3rSoU', u'dummy_UyBFm', u'dummy_aYu7g', u'dummy_on [truncated]... != {'bond11': {'nics': ['dummy_3rSoU', 'dummy_aYu7g', 'dummy_onPCZ'], 'options': '' [truncated]...
+ {'bond11': {'nics': ['dummy_3rSoU', 'dummy_aYu7g', 'dummy_onPCZ'],
- {'bond11': {u'nics': [u'dummy_3rSoU',
-                       u'dummy_UyBFm',
-                       u'dummy_aYu7g',
-                       u'dummy_onPCZ'],
-             u'options': ''}}
?             -

+             'options': ''}}
-------------------- >> begin captured logging << --------------------
root: INFO: Adding bond11({'nics': ['dummy_3rSoU', 'dummy_aYu7g'], 'options': ''})
root: INFO: Adding bond11({'nics': ['dummy_3rSoU', 'dummy_aYu7g', 'dummy_onPCZ'], 'options': ''})
--------------------- >> end captured logging << ---------------------

-- 
To view, visit https://gerrit.ovirt.org/44539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If91b46657be8a5a42a118b23155d059df379727e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list