Change in vdsm[master]: v2v: get VM information from OVA file

shavivi at redhat.com shavivi at redhat.com
Sun Aug 16 07:47:17 UTC 2015


Shahar Havivi has posted comments on this change.

Change subject: v2v: get VM information from OVA file
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/43271/10/vdsm/v2v.py
File vdsm/v2v.py:

Line 185:     _add_general_ovf_info(vm, root, ns)
Line 186:     _add_disks_ovf_info(vm, root, ns)
Line 187:     _add_networks_ovf_info(vm, root, ns)
Line 188: 
Line 189:     return response.success(vmList=vm)
> ok, but let's make a step further: now this is misleading, is not a list an
well if you look at the bridge.py you will see the all the verbs that return a single vm (vm_create, vm_cont, change_cd, change_floppy,pause_vm etc) all return vmList key for a single VM.
Line 190: 
Line 191: 
Line 192: def get_converted_vm(job_id):
Line 193:     try:


-- 
To view, visit https://gerrit.ovirt.org/43271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c55c846f837bb5bf363717e05daabf5ee6631ca
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list