Change in vdsm[master]: StorageDomainManifest: move extend and extendVolume

alitke at redhat.com alitke at redhat.com
Fri Aug 14 19:11:50 UTC 2015


Adam Litke has posted comments on this change.

Change subject: StorageDomainManifest: move extend and extendVolume
......................................................................


Patch Set 19:

(2 comments)

https://gerrit.ovirt.org/#/c/42266/19/tests/sdm_indirection_tests.py
File tests/sdm_indirection_tests.py:

Line 33:         self.__class__._classmethod_calls = []
Line 34: 
Line 35:     @classmethod
Line 36:     def record_classmethod_call(cls, fn, args):
Line 37:         cls._classmethod_calls.append((fn, args))
> We should have also get_classmethod_calls() class method, so we don't have 
Done
Line 38: 
Line 39:     @recorded
Line 40:     def replaceMetadata(self, md):
Line 41:         pass


Line 142:     def __init__(self):
Line 143:         self.stat = None
Line 144:         self._manifest = self.manifestClass()
Line 145: 
Line 146:     def get_classmethod_calls(self):
> Should be implemented in the fake manifest class above, so we can eliminate
Done
Line 147:         return self._manifest.__class__._classmethod_calls
Line 148: 
Line 149: 
Line 150: class FakeBlockStorageDomain(blockSD.BlockStorageDomain, FakeDomainMixin):


-- 
To view, visit https://gerrit.ovirt.org/42266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ad1769d7e4db6fc0883b37a67d071c278b96c8b
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list