Change in vdsm[master]: gluster: fix AttributeError and TypeError in exception.py

tjeyasin at redhat.com tjeyasin at redhat.com
Fri Aug 14 10:25:12 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: fix AttributeError and TypeError in exception.py
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/41530/3//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Currently whenever an exception raised with extra arguments
Line 10: apart from rc, out, err; the exception failed with
Line 11: AttributeError and TypeError due to base class constructor is
Line 12: not been called explicitly.
> when was this introduced? what's the exact stack trace? 
It fixes the attribute error and the actual traceback is as follows:

Traceback (most recent call last):
  File "/usr/share/vdsm/vdsClient.py", line 2683, in <module>
    code, message = commands[command][0](commandArgs)
  File "/usr/share/vdsm/vdsClientGluster.py", line 394
  File "/usr/lib64/python2.6/xmlrpclib.py", line 1199, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib64/python2.6/xmlrpclib.py", line 1489, in __request
    verbose=self.__verbose
  File "/usr/lib64/python2.6/xmlrpclib.py", line 1253, in request
    return self._parse_response(h.getfile(), sock)
  File "/usr/lib64/python2.6/xmlrpclib.py", line 1392, in _parse_response
    return u.close()
  File "/usr/lib64/python2.6/xmlrpclib.py", line 838, in close
    raise Fault(**self._stack[0])
Fault: <Fault 1: "<type 'exceptions.AttributeError'>:'GlusterHookCheckSumMismatchException' object has no attribute 'out'">
Line 13: 
Line 14: This patch fixes AttributeError and TypeError when the
Line 15: exception raised with an extra arguments by calling the
Line 16: ancestor's __init__ method explicitly.


-- 
To view, visit https://gerrit.ovirt.org/41530
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4c72daf30aee8f0024b1ef9ee064a205a500620
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: rebecca salomi <rebekkalsalomi at gmail.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list