Change in vdsm[master]: gluster: fix AttributeError and TypeError in exception.py

rnachimu at redhat.com rnachimu at redhat.com
Fri Aug 14 08:39:32 UTC 2015


Ramesh N has posted comments on this change.

Change subject: gluster: fix AttributeError and TypeError in exception.py
......................................................................


Patch Set 3: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/41530/3/vdsm/gluster/exception.py
File vdsm/gluster/exception.py:

Line 528: 
Line 529: class GlusterHookCheckSumMismatchException(GlusterException):
Line 530:     code = 4508
Line 531: 
Line 532:     def __init__(self, computedMd5Sum=None, expectedMd5Sum=None):
> how adding defaults related to this patch? do you really want to raise a Gl
Dan and Tim: Looks like default arguments are required because of an issue in python http://bugs.python.org/issue15440

We can find more info about this issue from Bala's old patch https://gerrit.ovirt.org/#/c/4750/5
Line 533:         GlusterHookException.__init__(self)
Line 534:         self.computedMd5Sum = computedMd5Sum
Line 535:         self.expectedMd5Sum = expectedMd5Sum
Line 536:         self.message = 'Hook file check sum:%s mismatch %s' % (computedMd5Sum,


-- 
To view, visit https://gerrit.ovirt.org/41530
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4c72daf30aee8f0024b1ef9ee064a205a500620
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: rebecca salomi <rebekkalsalomi at gmail.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list