Change in vdsm[master]: storage: Cleanup sd.getVAllocSize redirection
nsoffer at redhat.com
nsoffer at redhat.com
Thu Aug 13 22:53:42 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: storage: Cleanup sd.getVAllocSize redirection
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Nice!, -1 for visibility
https://gerrit.ovirt.org/#/c/44829/1/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 437:
Line 438: return int(size)
Line 439:
Line 440: def getVAllocSize(self, imgUUUID, volUUID):
Line 441: return self.getVSize(imgUUUID, volUUID)
Since getVAllocSize is just an alias, we can use the old code:
getVallocSize = getVSize
Do you have any reason to use this form instead?
Line 442:
Line 443: def getLeasesFilePath(self):
Line 444: # TODO: Determine the path without activating the LV
Line 445: lvm.activateLVs(self.sdUUID, [sd.LEASES])
--
To view, visit https://gerrit.ovirt.org/44829
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a277caeee1747e8c9e2869a557d3b97fa767ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list