Change in vdsm[master]: udevadm: use udevadm module facilities for functions

nsoffer at redhat.com nsoffer at redhat.com
Thu Aug 13 14:42:35 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: udevadm: use udevadm module facilities for functions
......................................................................


Patch Set 2: Code-Review-1

Generally it is better to do code moves and changes in different patches. However, moving code to udevadm so we have a mess, using different methods to find udevadm, different methods to run it, and different errors raised, and then fixing the mess in the next patch does not make any sense.

Please do this:

- Remove unneeded code in supervdsm, before moving code here, so
  we have less code to move.
- Use the infrastructure in udevadm module. Make one good and
  complete patch.

-- 
To view, visit https://gerrit.ovirt.org/44809
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30db46bc578ce8c3acc30c0aaee1e2545ea4196
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list