Change in vdsm[master]: supervdsm: generalize udevTrigger method
nsoffer at redhat.com
nsoffer at redhat.com
Thu Aug 13 14:33:35 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/44767/4//COMMIT_MSG
Commit Message:
Line 12: matches in a more generic function.
Line 13:
Line 14: This patch refactors udevTrigger to include attr_matches and
Line 15: property_matches. When dict is supplied to these, they're expanded to
Line 16: the command.
We don't use dict for these options now, please update the text to describe the actual implementation.
Even better, add an example of a new call, so reviewers can
understand the change from reading the commit message.
Line 17:
Line 18: Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7
--
To view, visit https://gerrit.ovirt.org/44767
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list