Change in vdsm[master]: tests: Introduce indirection tests for storage refactoring
nsoffer at redhat.com
nsoffer at redhat.com
Thu Aug 13 11:34:36 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: tests: Introduce indirection tests for storage refactoring
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
Good tests, now we see that we introduced a regression in commit 9e5ab860, removing getVAllocSize for block storage domain.
The original code had:
getVAllocSize = getVSize
We should keep these semantics for now.
https://gerrit.ovirt.org/#/c/44098/2/tests/sdm_indirection_tests.py
File tests/sdm_indirection_tests.py:
Line 60:
Line 61: @recorded
Line 62: def getVSize(self, imgUUID, volUUID):
Line 63: pass
Line 64:
Where is getVAllocSize?
Line 65: @recorded
Line 66: def getLeasesFilePath(self):
Line 67: pass
Line 68:
Line 137:
Line 138: @permutations([
Line 139: ['getReadDelay'],
Line 140: ['replaceMetadata', 1],
Line 141: ['getVSize', 2],
Where is getVAllocSize?
Line 142: ['getLeasesFilePath'],
Line 143: ['getIdsFilePath'],
Line 144: ['getIsoDomainImagesDir'],
Line 145: ['getMDPath'],
--
To view, visit https://gerrit.ovirt.org/44098
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I336b543aa7ba019c91104e860a28bb40acc268b9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list