Change in vdsm[master]: FileStorageDomainManifest: move getVSize
nsoffer at redhat.com
nsoffer at redhat.com
Thu Aug 13 11:19:30 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: FileStorageDomainManifest: move getVSize
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/44564/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:
Line 177:
Line 178: def getVAllocSize(self, imgUUID, volUUID):
Line 179: """ Returns file volume allocated size in bytes. """
Line 180: volPath = os.path.join(self.mountpoint, self.sdUUID, 'images',
Line 181: imgUUID, volUUID)
For future patch - the code for getting volume path is duplicated with getVsize.
Also, both call self.oop.os.stat, maybe we should have a helper returning stats for volume.
Line 182: stat = self.oop.os.stat(volPath)
Line 183:
Line 184: return stat.st_blocks * ST_BYTES_PER_BLOCK
Line 185:
--
To view, visit https://gerrit.ovirt.org/44564
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c391448b233fac8717d9c85c1dbc547f36eba6f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list