Change in vdsm[master]: vmstats: fine-grained KeyError handling

fromani at redhat.com fromani at redhat.com
Wed Aug 12 15:40:14 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vmstats: fine-grained KeyError handling
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/43777/3//COMMIT_MSG
Commit Message:

Line 7: vmstats: fine-grained KeyError handling
Line 8: 
Line 9: one of the cornerstones behind bulk stats implementation is
Line 10: to fail only in critical conditions (e.g. memory exaustion)
Line 11: and report as much as partial data it is possible.
> Would you please detail cases where it is fine not to report some of the va
Good point. My problem here is just that libvirt doesn't offer a clear list on which it can omit to provide these values.

Let's fix this incrementally. During migrations, on dest side, libvirt may omit block stats data (example here:
http://fpaste.org/254396/)

So, will add guards and swallow silently exceptions only on such cases.
Line 12: 
Line 13: This means that is legal to omit random keys in the output.
Line 14: We must make sure that our code deals with this case
Line 15: gracefully.


-- 
To view, visit https://gerrit.ovirt.org/43777
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04ecbf98d36d576ede3c3cde36586245ea5e4218
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list