Change in vdsm[master]: supervdsm: Decorator for supervdsm proxied calls.

dkuznets at redhat.com dkuznets at redhat.com
Wed Aug 12 11:31:17 UTC 2015


Dima Kuznetsov has posted comments on this change.

Change subject: supervdsm: Decorator for supervdsm proxied calls.
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/44598/4/tests/functional/supervdsmFuncTests.py
File tests/functional/supervdsmFuncTests.py:

Line 53:         self.assertIn(o, _test_list)
Line 54: 
Line 55:     def test_proxied_call_fails_on_unknown_function(self):
Line 56:         with self.assertRaises(ImportError):
Line 57:             foo()
> Import error? maybe better to raise homemade exception - such as NotExistSV
I don't like homemade exceptions, I prefer using the ones provided by python. I think this can be a runtime error as well.
Line 58: 
Line 59:     def test_proxied_call_non_decorated_function(self):
Line 60:         with self.assertRaises(RuntimeError):
Line 61:             supervdsm.proxied_call(utils.tobool)(None)


-- 
To view, visit https://gerrit.ovirt.org/44598
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibea2b07b91a7faffda16c71c6b5831f96d116c15
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list