Change in vdsm[master]: v2v: get VM information from OVA file

shavivi at redhat.com shavivi at redhat.com
Wed Aug 12 09:45:40 UTC 2015


Shahar Havivi has posted comments on this change.

Change subject: v2v: get VM information from OVA file
......................................................................


Patch Set 9:

(2 comments)

https://gerrit.ovirt.org/#/c/43271/9/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 3965: ##
Line 3966: {'command': {'class': 'Host', 'name': 'getExternalVmFromOva'},
Line 3967:   'data': {'ova_path': 'str'},
Line 3968:   'returns': ['ExternalVmInfo']}
Line 3969: 
> Oops.  You never define the 'ExternalVmInfo' type.  Also, why are you retur
its not a new type its define in line 3900 and we use it for other verbs as well.
For the VM array you are right this is an Engine constraint as Arik mention here: https://gerrit.ovirt.org/#/c/43271/4/vdsm/v2v.py@179
I will change it to a single VM and ask Arik to fix it in the engine.
Line 3970: 
Line 3971: ##
Line 3972: # @Host.convertExternalVm:
Line 3973: #


https://gerrit.ovirt.org/#/c/43271/9/vdsm/v2v.py
File vdsm/v2v.py:

Line 699:         vm['vmName'] = vmName.text
Line 700:     else:
Line 701:         raise V2VError('Error parsing ovf information: no ovf:Name')
Line 702: 
Line 703:     memSize = node.find('.//ovf:Item[rasd:ResourceType="4"]/'
> ResouceType="4" <-- seems we should have some constants defined for these.
Done
Line 704:                         'rasd:VirtualQuantity', ns)
Line 705:     if memSize is not None:
Line 706:         vm['memSize'] = int(memSize.text)
Line 707:     else:


-- 
To view, visit https://gerrit.ovirt.org/43271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c55c846f837bb5bf363717e05daabf5ee6631ca
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list