Change in vdsm[master]: supervdsm: Decorator for supervdsm proxied calls.

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Wed Aug 12 08:16:17 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: supervdsm: Decorator for supervdsm proxied calls.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/44598/3/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 495: 
Line 496:         try:
Line 497:             ret = func(*args, **kwargs)
Line 498:         except:
Line 499:             self.log.exception('error in %s.%s', mod_name, func_name)
Shouldn't we return any errors to the client?
Line 500:             raise
Line 501: 
Line 502:         self.log.debug('%s.%s returned with %s', mod_name, func_name, ret)
Line 503:         return ret


-- 
To view, visit https://gerrit.ovirt.org/44598
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibea2b07b91a7faffda16c71c6b5831f96d116c15
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list