Change in vdsm[master]: ssl: configurable implementation
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Wed Aug 12 08:02:26 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44494/3/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:
Line 31: from .config import config
Line 32: try:
Line 33: from . import m2cutils as sslutils
Line 34: except ImportError:
Line 35: from . import sslutils
> Adding this import everywhere is not a good idea. This should be moved to t
Done
Line 36:
Line 37:
Line 38: _COMMAND_CONVERTER = {
Line 39: 'ping': 'Host.ping',
--
To view, visit https://gerrit.ovirt.org/44494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list