Change in vdsm[master]: hostdev: add udev rules for USB devices

mpolednik at redhat.com mpolednik at redhat.com
Tue Aug 11 22:07:55 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: hostdev: add udev rules for USB devices
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/44679/3/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 296:             raise OSError(errno.EINVAL, "Could not trigger change for device \
Line 297:                           %s, out %s\nerr %s" % (guid, out, err))
Line 298: 
Line 299:     @logDecorator
Line 300:     def udevTriggerUSB(self, bus, device):
> I don't see a need to backport half-baked api, and I don't want to support 
Please see the followup - I believe that udevadm things belong to udevadm module. Backport IS needed, because this is requirement (bug fix) for 3.6 USB passthrough.
Line 301:         self.__udevReloadRules('usb_' + '_'.join((bus, device)))
Line 302:         cmd = [EXT_UDEVADM, 'trigger', '--verbose', '--action', 'change',
Line 303:                '--attr-match=busnum={}'.format(bus),
Line 304:                '--attr-match=devnum={}'.format(device)]


-- 
To view, visit https://gerrit.ovirt.org/44679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f72f63186187254cd4aded0a2e6c396001ca28b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list