Change in vdsm[master]: net: monitor: validate passed groups argument

osvoboda at redhat.com osvoboda at redhat.com
Mon Aug 10 18:20:45 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: net: monitor: validate passed groups argument
......................................................................


Patch Set 3:

Petr, I posted some advice on removing the extraneous usage of str().

Can you please send a follow-up that will replace str() with one of my proposals? Both patterns I mention are used in VDSM codebase, and are preferred to creating a temporary str object :-)

-- 
To view, visit https://gerrit.ovirt.org/44530
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cef124e79a61cf7fa2af2b0c91803c3994c99d7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list