Change in vdsm[master]: net: monitor: validate passed groups argument

alitke at redhat.com alitke at redhat.com
Mon Aug 10 15:18:40 UTC 2015


Adam Litke has submitted this change and it was merged.

Change subject: net: monitor: validate passed groups argument
......................................................................


net: monitor: validate passed groups argument

If we pass an invalid groups argument, Monitor raises exception into
another thread and therefore it's hard to find and debug such a problem.

Now we validate passed groups in __init__ method in main thread.

Change-Id: I5cef124e79a61cf7fa2af2b0c91803c3994c99d7
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44530
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
---
M lib/vdsm/netlink/monitor.py
M tests/netlinkTests.py
2 files changed, 11 insertions(+), 1 deletion(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified



-- 
To view, visit https://gerrit.ovirt.org/44530
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5cef124e79a61cf7fa2af2b0c91803c3994c99d7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list