Change in vdsm[master]: network: bridge inherits DHCP unique identifier from its DHC...
ibarkan at redhat.com
ibarkan at redhat.com
Sun Aug 9 06:33:18 UTC 2015
Ido Barkan has posted comments on this change.
Change subject: network: bridge inherits DHCP unique identifier from its DHCP-enabled port
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
bravo for solving this. -1 for logic location.
https://gerrit.ovirt.org/#/c/44539/3/vdsm/network/api.py
File vdsm/network/api.py:
Line 316: _update_bridge_ports_mtu(net_ent.name, mtu)
Line 317: else:
Line 318: net_ent_to_configure = net_ent
Line 319:
Line 320: if bridged and net_ent.port and bootproto == 'dhcp':
I _could_ live with it if there is no choice, but I think this logic should be located at the models level or under _objectivizeNetwork. it feels wrong because you alter net_ent after objectivizeNetwork worked so hard to create it.
Line 321: _inherit_dhcp_unique_identifier(net_ent, _netinfo)
Line 322:
Line 323: if net_ent_to_configure is not None:
Line 324: logging.info("Configuring device %s", net_ent_to_configure)
--
To view, visit https://gerrit.ovirt.org/44539
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If91b46657be8a5a42a118b23155d059df379727e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list