Change in vdsm[master]: sampling: Handle numa nodes with zero memory assigned
rmohr at redhat.com
rmohr at redhat.com
Fri Aug 7 07:48:56 UTC 2015
Roman Mohr has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44121/3/tests/samplingTests.py
File tests/samplingTests.py:
Line 376: expected = {0: {'memPercent': 100, 'memFree': '0'}}
Line 377:
Line 378: with self._monkeyPatchedMemorySample(freeMemory='0', totalMemory='0'):
Line 379: memorySample = sampling.NumaNodeMemorySample()
Line 380: self.assertEqual(memorySample.nodesMemSample, expected)
> I'd like to go in the direction of one assert per test. Let's consider this
Done :)
Had a pep8 error anyway.
Line 381: with self._monkeyPatchedMemorySample(freeMemory='0', totalMemory=0):
Line 382: memorySample = sampling.NumaNodeMemorySample()
Line 383: self.assertEqual(memorySample.nodesMemSample, expected)
Line 384:
--
To view, visit https://gerrit.ovirt.org/44121
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6be69e715e9b4a0cc8ded744b0bcc192a466c6c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list