Change in vdsm[master]: network: bridge inherits DHCP client identifier from its DHC...

osvoboda at redhat.com osvoboda at redhat.com
Thu Aug 6 23:14:45 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: network: bridge inherits DHCP client identifier from its DHCP-enabled port
......................................................................


Patch Set 1: Verified+1

The newly introduced testDhcpReplaceNicWithBridge confirms that an IP address originally obtained for a NIC is leased also to a bridge that replaced it.

tcpdump output verifies that dhcp-client-identifier (DUID-LLT containing a part of an iface's MAC address, timestamp the identifier was generated and the full MAC address) sent by dhclient is the same for both DHCP discover requests.

Of course the patch is preliminary but in essence it works and solves the problem. After a little cleanup (a "break" in _inherit_dhcp_client_identifier would be nice) it is ready for merge and backport to 3.6 branch.

-- 
To view, visit https://gerrit.ovirt.org/44539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If91b46657be8a5a42a118b23155d059df379727e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list