Change in vdsm[master]: storageServer: Add MountConnection.__ne__

danken at redhat.com danken at redhat.com
Thu Aug 6 21:02:34 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: storageServer: Add MountConnection.__ne__
......................................................................


storageServer: Add MountConnection.__ne__

Classes implementing __eq__ should also implement __ne__ so != work as
expected. Add the missing implementation to MountConnection and to the
ExampleConnection.

This change fixes one broken test.

Change-Id: I209bf318ac840f0d5fb8c4c3e1819ead90015ca3
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44293
Continuous-Integration: Jenkins CI
Reviewed-by: Freddy Rolland <frolland at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/storageServerTests.py
M vdsm/storage/storageServer.py
2 files changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/44293
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I209bf318ac840f0d5fb8c4c3e1819ead90015ca3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list