Change in vdsm[master]: storage: validate vdsm rwx permissions for file storage

gpadgett at redhat.com gpadgett at redhat.com
Thu Aug 6 20:36:39 UTC 2015


Greg Padgett has posted comments on this change.

Change subject: storage: validate vdsm rwx permissions for file storage
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/44442/2/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 68:         getProcPool().fileUtils.validateAccess(dirPath)
Line 69:         supervdsm.getProxy().validateAccess(
Line 70:             constants.VDSM_USER,
Line 71:             (constants.DISKIMAGE_GROUP, constants.METADATA_GROUP), dirPath,
Line 72:             (os.R_OK | os.W_OK | os.X_OK))
> Are you sure about the second parameter (constants.DISKIMAGE_GROUP, constan
Done (doesn't really matter in this case, but seems cleaner)
Line 73:         supervdsm.getProxy().validateAccess(
Line 74:             constants.QEMU_PROCESS_USER,
Line 75:             (constants.DISKIMAGE_GROUP, constants.METADATA_GROUP), dirPath,
Line 76:             (os.R_OK | os.X_OK))


-- 
To view, visit https://gerrit.ovirt.org/44442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8276c36042bef57c80c8920041b1f3446cdfc372
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list