Change in vdsm[master]: v2v: import abort/done status fix

fromani at redhat.com fromani at redhat.com
Thu Aug 6 08:52:46 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: v2v: import abort/done status fix
......................................................................


Patch Set 2:

(1 comment)

a couple of questions inside, hence -1 for visibility

https://gerrit.ovirt.org/#/c/44470/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 381:                                   (self._id, self._proc.returncode,
Line 382:                                    self._proc.stderr.read(1024)))
Line 383: 
Line 384:         logging.info('Job %r finished import successfully', self._id)
Line 385:         if self._status != STATUS.ABORTED:
ok about the concept, but after a closer look I think the above log (line 384) is now misleading.

Moreover, question:
IIUC, if the job is aborted(), shouldn't returncode be != 0, hence we never reach this code?
Line 386:             self._status = STATUS.DONE
Line 387: 
Line 388:     def _execution_environments(self):
Line 389:         env = {'LIBGUESTFS_BACKEND': 'direct'}


-- 
To view, visit https://gerrit.ovirt.org/44470
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fc3febe19a9602df63fa414edf7446a02416c66
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list