Change in vdsm[master]: virt: Handle disconnects only if endpoints match

vfeenstr at redhat.com vfeenstr at redhat.com
Thu Aug 6 08:11:54 UTC 2015


Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Handle disconnects only if endpoints match
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/43141/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 918:                 self.shutdown(delay=delay, reboot=False, timeout=timeout,
Line 919:                               message='Scheduled shutdown on disconnect',
Line 920:                               force=True)
Line 921: 
Line 922:     def onDisconnect(self, detail=None, clientIp='', clientPort=''):
> 'detail' seems unused. If really so, let's drop it in a future, unrelated p
ack
Line 923:         if self.conf['clientIp'] != clientIp:
Line 924:             self.log.debug('Ignoring disconnect event because ip differs')
Line 925:             return
Line 926:         if self._clientPort and self._clientPort != clientPort:


-- 
To view, visit https://gerrit.ovirt.org/43141
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfb3441407aa6e7bc31d37304bce0076e12bb1a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list