Change in vdsm[master]: storage: validate vdsm rwx permissions for file storage

nsoffer at redhat.com nsoffer at redhat.com
Wed Aug 5 20:35:52 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storage: validate vdsm rwx permissions for file storage
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/44442/1//COMMIT_MSG
Commit Message:

Line 11: an error; however, these errors were not always clear nor did they help
Line 12: the user (e.g. a general Error 100, such as in the referenced bug).
Line 13: 
Line 14: With an explicit check, we can ensure the failure happens up-front and
Line 15: gives a meaningful error message to the user.
To make sure I understand your intention:

- You think we don't check the required permissions at the start of the flow
- Later some operation fails because we don't have permissions
- We do not handle this error, so engine get general error
- You suggest to check the required permissions at the start of the flow, avoiding the unhandled error later

Right?
Line 16: 
Line 17: Change-Id: I8276c36042bef57c80c8920041b1f3446cdfc372
Line 18: Bug-Url: https://bugzilla.redhat.com/1112171


Line 14: With an explicit check, we can ensure the failure happens up-front and
Line 15: gives a meaningful error message to the user.
Line 16: 
Line 17: Change-Id: I8276c36042bef57c80c8920041b1f3446cdfc372
Line 18: Bug-Url: https://bugzilla.redhat.com/1112171
According to the bug, the operation fail in the first try, and succeed in the seconds. So I wonder if we should fail at all in the first time.

The bug is also missing minimal data for understanding this issue, so I think we should first collect all the info and explain
the nature of this problem on the bug, before trying to fix it.


-- 
To view, visit https://gerrit.ovirt.org/44442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8276c36042bef57c80c8920041b1f3446cdfc372
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list