Change in vdsm[master]: hostdev: fix addressing

mpolednik at redhat.com mpolednik at redhat.com
Wed Aug 5 14:03:19 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: hostdev: fix addressing
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/44177/4/tests/hostdevTests.py
File tests/hostdevTests.py:

Line 117:     <interface managed="no" type="hostdev">
Line 118:             <driver name="vfio"/>
Line 119:             <source>
Line 120:                     <address type="pci"
Line 121:                     bus="5" domain="0" function="7" slot="16"/>
> why is this needed?
src/conf/domain_conf.c
virDomainHostdevDefParseXMLSubsys

/* @type is passed in from the caller rather than read from the
 * xml document, because it is specified in different places for
 * different kinds of defs - it is an attribute of
 * <source>/<address> for an intelligent hostdev (<interface>),
 * but an attribute of the toplevel element for a standard
 * <hostdev>.  (the functions we're going to call expect address
 * type to already be known).
 */

Guess I'm not able to supply better answer. :)
Line 122:             </source>
Line 123:             <mac address="ff:ff:ff:ff:ff:ff"/>
Line 124:             <vlan>
Line 125:                     <tag id="3"/>


-- 
To view, visit https://gerrit.ovirt.org/44177
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12592dd53f8af25fe8e1312b810e6b6f48411083
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list