Change in vdsm[master]: tests: Enhance permutations tests

danken at redhat.com danken at redhat.com
Wed Aug 5 08:36:34 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Enhance permutations tests
......................................................................


tests: Enhance permutations tests

- Move nested class to module to avoid clumsy self.Class syntax. We don't
  really need to have a nested class since it is not a TestCase class.
- Test instance methods instead of class functions
- Separate tests for unrelated features. We don't want tests for
  expanded method to fail because we did not remove the original method.
- Use hasattr() for attribute testing
- Test also mulitple arguments
- Add test for sub-classing permuted class.

Change-Id: I3e28fb348e688970611ddd2e66ed6869047b5317
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44214
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke <alitke at redhat.com>
---
M tests/testlibTests.py
1 file changed, 49 insertions(+), 15 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/44214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3e28fb348e688970611ddd2e66ed6869047b5317
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list