Change in vdsm[master]: nettestlib: Replace brctl with ip
ibarkan at redhat.com
ibarkan at redhat.com
Wed Aug 5 08:06:19 UTC 2015
Ido Barkan has posted comments on this change.
Change subject: nettestlib: Replace brctl with ip
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44379/3/tests/nettestlib.py
File tests/nettestlib.py:
Line 73: class Bridge(Interface):
Line 74:
Line 75: def addDevice(self):
Line 76: check_call([EXT_IP, 'link', 'add', 'dev', self.devName, 'type',
Line 77: 'bridge'])
sadly, we must test it also on el6. iproute2 had a few changes since then (for example adding 'nomaster' verb) so I suspect it might not support all this goodness, can you verify please?
Line 78: self._ifUp()
Line 79:
Line 80: def delDevice(self):
Line 81: self._ifDown()
--
To view, visit https://gerrit.ovirt.org/44379
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf053d3e3d8c7c66e2eb55b93cb943fc9cb2a951
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list