Change in vdsm[master]: fc-connect-server: Support FCP on connect server

frolland at redhat.com frolland at redhat.com
Tue Aug 4 13:11:34 UTC 2015


Freddy Rolland has posted comments on this change.

Change subject: fc-connect-server: Support FCP on connect server
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/44011/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 239:             cred = iscsi.ChapCredentials(username, password)
Line 240: 
Line 241:         params = storageServer.IscsiConnectionParameters(target, iface, cred)
Line 242:     elif typeName == 'fcp':
Line 243:         params = storageServer.FcpConnectionParameters('fcp')
> Please remove type argument.
Fixed with empty nametuple
Line 244:     else:
Line 245:         raise se.StorageServerActionError()
Line 246: 
Line 247:     return storageServer.ConnectionInfo(typeName, params)


-- 
To view, visit https://gerrit.ovirt.org/44011
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I408d8364278a1a502fc94a2e6537cb160c716ff1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list