Change in vdsm[master]: fc-connect-server: Add FcpConnection class

nsoffer at redhat.com nsoffer at redhat.com
Tue Aug 4 08:25:23 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: fc-connect-server: Add FcpConnection class
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/44010/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 68: NfsConnectionParameters = namedtuple("NfsConnectionParameters",
Line 69:                                      "export, retrans, timeout, version, "
Line 70:                                      "extraOptions")
Line 71: 
Line 72: FcpConnectionParameters = namedtuple("FcpConnectionParameters", "type")
> What is type?
Actually I think we can remove this, and use None or empty tuple when creating a ConnectionInfo for FCP.
Line 73: 
Line 74: ConnectionInfo = namedtuple("ConnectionInfo", "type, params")
Line 75: 
Line 76: 


-- 
To view, visit https://gerrit.ovirt.org/44010
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a2c937cb997244df7910fc7cfcae11b088d3cdb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list