Change in vdsm[master]: utils: add CommandStream class

nsoffer at redhat.com nsoffer at redhat.com
Thu Apr 30 22:32:05 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: utils: add CommandStream class
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.ovirt.org/#/c/33909/8/tests/utilsTests.py
File tests/utilsTests.py:

Line 777: 
Line 778:         c = self._startCommand(cmd)
Line 779:         p = utils.CommandStream(c,
Line 780:             recv_data if recv_out else self.assertUnexpectedCall,
Line 781:             recv_data if recv_err else self.assertUnexpectedCall)
pep8 does not like the indentation here:

 tests/utilsTests.py:780:13: E128 continuation line under-indented for visual indent
 tests/utilsTests.py:781:13: E128 continuation line under-indented for visual indent
Line 782: 
Line 783:         while not p.closed:
Line 784:             p.receive()
Line 785: 


Line 803: 
Line 804:         c = self._startCommand(cmd)
Line 805:         p = utils.CommandStream(c,
Line 806:             recv_data if recv_out else self.assertUnexpectedCall,
Line 807:             recv_data if recv_err else self.assertUnexpectedCall)
pep8 does not like the indentation here:

 tests/utilsTests.py:806:13: E128 continuation line under-indented for visual indent
 tests/utilsTests.py:807:13: E128 continuation line under-indented for visual indent
Line 808: 
Line 809:         c.stdin.write(text)
Line 810:         c.stdin.flush()
Line 811:         c.stdin.close()


-- 
To view, visit https://gerrit.ovirt.org/33909
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie015368bb9c5992e5c73a149277c59fc4ffbd570
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list