Change in vdsm[master]: network: wait for udev after configuring SRIOV

ibarkan at redhat.com ibarkan at redhat.com
Thu Apr 30 13:52:23 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: network: wait for udev after configuring SRIOV
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/40400/5/vdsm/network/api.py
File vdsm/network/api.py:

Line 542:         # This is a blocking call that should wait for all udev events to be
Line 543:         # handled. Since those include renaming devices, we should wait until
Line 544:         # udev finishes in order to report a stable hardware state in
Line 545:         # subsequent engine calls.
Line 546:         udevadm.settle(timeout=10)
> This can return before all the devices are ready. settle means - wait until
this is ideal, but I am not sure it worth the effort.
Line 547: 
Line 548: 
Line 549: def _persist_numvfs(device_name, numvfs):
Line 550:     dir_path = os.path.join(constants.P_VDSM_LIB, 'virtual_functions')


-- 
To view, visit https://gerrit.ovirt.org/40400
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04d63ca35aab585051c3d0a5f2652dbf2f91b080
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list