Change in vdsm[master]: virt: move libvirt helpers in a module

fromani at redhat.com fromani at redhat.com
Thu Apr 30 11:01:07 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: move libvirt helpers in a module
......................................................................


Patch Set 26:

(1 comment)

https://gerrit.ovirt.org/#/c/39332/26/vdsm/virt/libvirt_helpers.py
File vdsm/virt/libvirt_helpers.py:

Line 44: }
Line 45: 
Line 46: 
Line 47: def domain_event_to_string(event):
Line 48:     return _DOMAIN_EVENT_TO_STRING[event]
> Can be dropped (and occurences replaced by direct dict access)
Done
Line 49: 
Line 50: 
Line 51: class TimeoutError(libvirt.libvirtError):
Line 52:     pass


-- 
To view, visit https://gerrit.ovirt.org/39332
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35ceeb12bc96bea12281ce9c9a1481342dd3afa9
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list