Change in vdsm[master]: virt: move libvirt helpers in a module

fromani at redhat.com fromani at redhat.com
Thu Apr 30 09:19:46 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: move libvirt helpers in a module
......................................................................


Patch Set 24:

(1 comment)

https://gerrit.ovirt.org/#/c/39332/24/vdsm/virt/libvirt_helpers.py
File vdsm/virt/libvirt_helpers.py:

Line 41:                   "PM-Suspended")
Line 42: 
Line 43: 
Line 44: def event_to_string(event):
Line 45:     return _EVENT_STRINGS[event]
> Not sure if I missed it before, but does libvirt support the constants we u
Good point, will change
Line 46: 
Line 47: 
Line 48: class TimeoutError(libvirt.libvirtError):
Line 49:     pass


-- 
To view, visit https://gerrit.ovirt.org/39332
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35ceeb12bc96bea12281ce9c9a1481342dd3afa9
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list