Change in vdsm[master]: virt: Set source attributes consistently

alitke at redhat.com alitke at redhat.com
Wed Apr 29 14:24:04 UTC 2015


Adam Litke has posted comments on this change.

Change subject: virt: Set source attributes consistently
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/40064/5/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 335:             source.appendChildWithArgs('host', **hostAttrs)
Line 336:         elif self.diskType == DISK_TYPE.FILE:
Line 337:             source.setAttrs(file=self.path)
Line 338:             if self.device == 'cdrom' or self.device == 'floppy':
Line 339:                 source.setAttrs(startupPolicy='optional')
Much clearer code.  Thanks for the improvement.
Line 340:         else:
Line 341:             raise RuntimeError("Unsupported diskType %r", self.diskType)
Line 342: 
Line 343:         diskelem = self.createXmlElem('disk', self.diskType,


-- 
To view, visit https://gerrit.ovirt.org/40064
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcc3846428c7f2cc14cf19254617378b668404a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list