Change in vdsm[master]: virt: add unit test for getUnderlying* family of methods

ibarkan at redhat.com ibarkan at redhat.com
Wed Apr 29 13:22:40 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: virt: add unit test for getUnderlying* family of methods
......................................................................


Patch Set 8: Code-Review+1

fine! Somw extra work needed on those unit test when hostdev xml <interface type='hostdev'> nodes appear. Specifically, fakevmlib. Connection needs to implement nodeDeviceLookupByName which is not trivial. To do so, it might return a VirNodeDeviceStub instance that should be created from a real world SRIOV xml returned by libvirt for this api call on such a device.

-- 
To view, visit https://gerrit.ovirt.org/39364
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If202340d8f26cb79d2a8d306a114cd6dc39dada0
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list