Change in vdsm[master]: unbreak InterfaceSampleTests.

fromani at redhat.com fromani at redhat.com
Wed Apr 29 13:00:35 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: unbreak InterfaceSampleTests.
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/40346/5//COMMIT_MSG
Commit Message:

Line 7: unbreak InterfaceSampleTests.
Line 8: 
Line 9: testHostSampleReportsNewInterface and
Line 10: testHostSampleHandlesDisappearingVlanInterfaces made simpler. The
Line 11: compromise here is not testing the HostSmale() public interface, which
typo: should be HostSample
Line 12: is more correct, but harder to fake.
Line 13: 
Line 14: Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e


-- 
To view, visit https://gerrit.ovirt.org/40346
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list