Change in vdsm[master]: Move udevadm to lib/vdsm

danken at redhat.com danken at redhat.com
Wed Apr 29 10:56:08 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: Move udevadm to lib/vdsm
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/40119/3/tests/samplingTests.py
File tests/samplingTests.py:

Line 149:         s1 = sampling.InterfaceSample(lo)
Line 150:         s1.operstate = 'x'
Line 151:         self.assertEquals('operstate:x', s1.connlog_diff(s0))
Line 152: 
Line 153:     #@brokentest("Broken unless libvirtd is running")
this is a real pep8 error. add a space after the #.

but hey, this change is completely unrelated to settle!
Line 154:     @MonkeyPatch(libvirtconnection, '_read_password', read_password)
Line 155:     @ValidateRunningAsRoot
Line 156:     def testHostSampleReportsNewInterface(self):
Line 157:         hs_before = sampling.HostSample(os.getpid())


-- 
To view, visit https://gerrit.ovirt.org/40119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list