Change in vdsm[master]: events: sending stats with vm status change event

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Apr 28 10:47:40 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: events: sending stats with vm status change event
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40204/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 368:         return status
Line 369: 
Line 370:     def _set_lastStatus(self, value):
Line 371:         with self._statusLock:
Line 372:             self._send_status_event(value)
> Have you considered a race between this event and the periodic getAllVmStat
Yes. It is main problem to solve. We want to introduce in memory versioning of status changes.
Line 373:             if self._lastStatus == vmstatus.DOWN:
Line 374:                 self.log.warning(
Line 375:                     'trying to set state to %s when already Down',
Line 376:                     value)


-- 
To view, visit https://gerrit.ovirt.org/40204
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list