Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc

danken at redhat.com danken at redhat.com
Tue Apr 28 10:15:49 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/39203/5/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:

Line 71:     def __del__(self):
Line 72:         self._client.close()
Line 73: 
Line 74: 
Line 75: def connect(cif, client_socket):
"cif" is part of vdsm server. requiring an instance thereof in a vdsm *client* library, makes very little sense.

Cannot you define a json rpc client without it? why?
Line 76:     stompClient = cif.createStompClient(client_socket)
Line 77:     if stompClient is None:
Line 78:         raise Exception("Failed to create a stomp client")
Line 79: 


-- 
To view, visit https://gerrit.ovirt.org/39203
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list