Change in vdsm[master]: jsonrpc: fix call to super ctor

nsoffer at redhat.com nsoffer at redhat.com
Tue Apr 28 09:08:29 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: jsonrpc: fix call to super ctor
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/39781/4/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 29: _STATE_ONESHOT = 4
Line 30: 
Line 31: 
Line 32: class JsonRpcError(RuntimeError):
Line 33:     def __init__(self, code, msg):
> I think we should avoid overriding __init__ altogather and implement this i
I agree, we can simplify all the errors here by keeping errors attributes and formatting in __str__ - but lets first merge this tiny one line fix to __init__.
Line 34:         super(JsonRpcError, self).__init__(
Line 35:             "[%d] %s" % (code, msg)
Line 36:         )
Line 37: 


-- 
To view, visit https://gerrit.ovirt.org/39781
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronheim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list